Modify

Ticket #317 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Module does not reload on module mach-ii.xml file change when MACHII_CONFIG_MODE = 0

Reported by: phil.thomas@… Owned by: peterfarrell
Priority: major Milestone: Mach-II 1.8.0 alpha
Component: framework - core Version: 1.5.0 - Framework
Keywords: module modules reload config mode dynamic Cc:
Blocked By: Blocking:

Description

I haven't been able to get dynamic module reloading to work when the module mach-ii.xml files changes when Mach-II is running in Dynamic Reload Mode.

I've been running with the patch pasted in below and the reloads work as expected now.

Running Mach-II Version 1.8.0.1571 built 2009-05-26 21:07:22

Index: MachII/1.8.0.alpha/framework/AppLoader.cfc

===================================================================

--- MachII/1.8.0.alpha/framework/AppLoader.cfc  (revision )

+++ MachII/1.8.0.alpha/framework/AppLoader.cfc  (working copy)

@@ -153,7 +153,7 @@

            <cfif NOT IsObject(getAppManager().getParent())>

                  <cfloop collection="#modules#" item="module">

                        <cfif modules[module].shouldReloadConfig()>

-                             <cfset modules[module].shouldReloadConfig() />

+                             <cfset modules[module].reloadModuleConfig(arguments.validateXml) />

                        </cfif>

                  </cfloop>

            </cfif>

Attachments

Change History

comment:1 Changed 3 years ago by peterfarrell

  • Keywords module modules reload config mode dynamic added
  • Priority changed from minor to major
  • Version changed from 1.8.0 - Framework to 1.5.0 - Framework
  • Status changed from new to assigned
  • Milestone set to Mach-II 1.8.0 alpha

@Phil, thanks for the defect report and related patch. I have confirmed the behavior you describe. Official fix to be committed is forth coming.

For the sake of history and potential future questions. This appears to affect Mach-II 1.5.0 and 1.6 series (1.6.0 and 1.6.1) according to version control. It appears that a lot of people have relied on the dashboard application since the introduction of modules about 18 months ago.

comment:2 Changed 3 years ago by peterfarrell

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [1592]) closes #317

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.